Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

Hermès Bélusca-Maïto
as documented in "Advanced Windows NT" by Jeffrey M. Richter (Microsoft Press),
and in https://is.muni.cz/el/1433/jaro2010/PB167/um/cv5/undocumented_CreateProcess.pdf .

for the STARTUPINFO::dwFlags structure member, whose purpose is to tell Win32k
that the created handles to the window station and desktop to which the
process is connecting to, can be inherited by its child processes.
It is used when starting interactive services.
Observed via API monitoring on Windows 2003.
Hermès Bélusca-Maïto
[WIN32K:NTUSER] In UserCreateWinstaDirectory(), use a string-safe printf, and use OBJ_KERNEL_HANDLE as well as a suitable desired access value in a ZwCreateDirectoryObject() call.
Hermès Bélusca-Maïto
[WIN32K:NTUSER] NtUserCloseDesktop(): Use ObCloseHandle instead.
Pierre Schweitzer
[NETSHELL] Update French translation to reflect 0725098
Hermès Bélusca-Maïto
[WIN32K:NTUSER] For processes that start without any window station and no desktops but manage these (e.g. winlogon.exe), assign their startup desktop when they assign a desktop to one of their threads.
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Detect when the NtUserCreateWindowStation() caller has provided an empty window station name, and if so, generate a name in the format: "Service-0x<luidhigh>-<luidlow>$" .

CORE-11933 and PR #621.
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Move the GetProcessLuid() function to the miscellaneous module.
Katayama Hirofumi MZ
[FONT][WIN32SS] Refactor the loop (3 of 5)
Hermès Bélusca-Maïto
[WIN32K:NTUSER] In UserSetProcessWindowStation(), use a duplicated window station handle to be set in the EPROCESS:Win32WindowStation cache.

Fixes most of the user32:desktop window station handle reference count tests.
Stanislav Motylkov
[NTOS:EX] Implement SystemFirmwareTableInformation class
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Make NtUserResolveDesktop() and IntResolveDesktop() work in a more Win2k3-compatible manner.
CORE-11933 and PR #621.

Since this API is also called from WINSRV when calling the AllocConsole() API,
it can be tested more-or-less easily. The internal helper IntResolveDesktop()
is also tested during process connection to a window station, when such process
first calls a USER32 or GDI32 function.
This is also the functionality tested by the user32:desktop apitest.

- Adjust how IntResolveDesktop() is called.
Katayama Hirofumi MZ
[FONT][WIN32SS] Refactor the loop (2 of 5)
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Rename some variables with more natural names.
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Split NtUserCreateWindowStation() into the part that captures the user-mode data and the internal worker IntCreateWindowStation() function, which will also be used later.

Add a FIXME note about how we currently handle the window station name.
Katayama Hirofumi MZ
[FONT][WIN32SS] Refactor the loop (4 of 5)
Stanislav Motylkov
[KERNEL32_APITEST] Add SystemFirmwareTableInformation tests

Thanks goes to Mark Jansen for help!
Hermès Bélusca-Maïto
[USER32] Implement the special case in CreateWindowStationW() that, when no window station name is provided (either NULL or empty string), does not open any WindowStation directory handle to be passed to the Win32k function.

Observed via API monitoring.
This corresponds to the case where Win32k creates a window station whose name is based on the logon session identifier for the calling process.

Add also a note about the fact that we need to use a per-session-based WindowStation directory name, as done already in Win32k.

CORE-11933 and PR #621.
Serge Gautherie
[APPVEYOR] Add 'BuildType: vssolution'

Disabled by default, though ready to be enabled.
Eric Kohl
[UMPNPMGR] Simplify PNP_GetDeviceRegProp
Eric Kohl
[SETUPAPI] SetupDiGetDeviceRegistryPropertyW call CM_Get_DevNode_Registry_Property_ExW for properties that can not be retrieved from the registry
Andrew Cook
CORE-14513 [CMAKE] Remove modules that are shipped with cmake (#575)

* Remove unused cmake modules - Both are unedited versions of modules provided by cmake itself
* Remove Compiler/GNU.cmake - Only chang was various _INIT flags, which are handled
* Remove Platform/Windows.cmake - There's no clear explination for this file being in reactos
and is simply an old version of the one in cmake
* Remove Platform/Windows-MSVC.cmake - _INIT variable changes moved to overrides-msvc.cmake
Remove /implib from link commands
* Remove CMakeDetermineASMCompiler.cmake - Only change from 3.2 is the addition of a compiler list for the generic ASM dialect, but toolchain files explicitly set a compiler so the list is never used
Paweł Cholewa
[SDK][Translation] Polish translation update (#495)

* Polish translation update in neteventmsg.mc
Stanislav Motylkov
[KERNEL32] Implement system firmware functions properly
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Code style fixes only.
Serge Gautherie
[LOG2LINES] Enforce "Iso" type when unpacking the Iso file

Work around some "7z" dealing with files not named "*.iso" as "Cab" type.
Issue at least with "7-Zip [64]  9.20" on "Ubuntu 16.04".

Hermès Bélusca-Maïto
[WIN32K:NTUSER] Fixes for NtUserCreateWindowStation(), IntCreateWindowStation() and NtUserOpenWindowStation().
CORE-11933 and PR #621.

We are potentially going to modify the window station name to be
created or opened, by one with the format "Service-0x<luidhigh>-<luidlow>$",
in case the user provides an empty name.
Since we want to use the user-mode ObjectAttributes structure pointer so
that the Object manager can correctly perform the access checks and the
capture, we actually need to construct the new window station name in the
user memory space! This allows us then to fetch the new name in the
ObjectAttributes structure so that Ob can use it.
All of this is performed under SEH.

For NtUserOpenWindowStation(), we also need to be Windows-compatible and
detect whether user-mode gave instead the special "Service-0x00000000-00000000$"
name (observed via API monitoring) that is used when one tries to open a
window station with empty name.
Katayama Hirofumi MZ
[FONT][WIN32SS] Refactor the loop (5 of 5)
Mark Jansen
[ATL] Improve the order of operations in CComPtr and CComQIIDPtr
  • Test VBox: test failed -  stdio
Katayama Hirofumi MZ
[FONT][WIN32SS] Refactor the loop (1 of 5)
Denis Malikov
[UPDATES] New stubs for Automatic Updates service and WUSA.exe. Presence of this modules required for installation by some NT6+ applications.
Mark Jansen
[ATL_APITEST] Add test for CComQIPtr (or rather, our gcc hack that slightly looks like it)
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Get rid of the cached window station Name member, and instead just use the name stored in the NT Object's header.
CORE-11933 and PR #621.

- Remove the related hack-FIXMEs;
- Adjust NtUserGetObjectInformation() in accordance.
- Retrieve the window-station/desktop object type string in NtUserGetObjectInformation()
  also from the NT Object's header.

Also simplify the UOI_FLAGS case of NtUserGetObjectInformation() by reading
the handle inheritance information directly from the OBJECT_HANDLE_INFORMATION
structure returned by ObReferenceObjectByHandle().
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Add a temporary winsta/desktop-connection hack for CSRSS/USERSRV (connection to WinSta0).

Normally CSRSS must not be connected to any winsta or desktop by default. It should manually connect
to a winsta/desktop only when it has to do some GUI operations, and then disconnect afterwards.

[USERSRV] Temporarily hackfix the harderror dialog display to the current input desktop.
Bișoc George
[OSK] Some enhancements for locales IT and RO (#416)

* Window element improvements for Italian and Romanian
Timo Kreuzer
[TRANSLATION] Polish translation of errcodes.mc (0-499) (#777)
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Similarly to what was done in USERSRV for harderrors, introduce the _scwprintf() helper function based on the imported _vscwprintf().
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Add an extra optional "Process" parameter to the GetProcessLuid() function to be used alternatively in place of "Thread" to retrieve the LUID.
Hermès Bélusca-Maïto
[WIN32K:NTUSER] Split NtUserCreateDesktop() into the part that captures the user-mode data and the internal worker IntCreateDesktop() function, which will also be used later.
Serge Gautherie
[GDI32_APITEST] Remove broken EngDeleteSemaphore.c (#655)

- Checks are actually uses-after-free, "by design" :-<
- Actual test code duplicates EngCreateSemaphore.c, EngAcquireSemaphore.c and EngReleaseSemaphore.c.
Petr Akhlamov
[OSK] Rearrange window elements for ru-RU and en-US locales (#412)

* Resize osk window at RU and EN(US) languages